You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're generating slugs from our product skus, which can include letters, numbers, -, and /. Because our slug source can contain numbers and dashes you can end up with a situation where dm-is-slug incorrectly interprets a slug as already in use.
An Example:
Assuming the following slug already exist:
f8z469-043
Then if we attempt to create a new product with the SKU of F8Z469, we end up with a slug of f8z469-44, instead of the expected f8z469.
For us, I've been thinking the best approach might be to allow a config option that skips trying slug variations. Our slugs should always be unique, as the SKUs we generate them from should always be. If they aren't I'd rather just see a validation error that complains about the uniqueness of the slug.
Whether this will work for everyone, I'm not sure :-)
The text was updated successfully, but these errors were encountered:
We're generating slugs from our product skus, which can include letters, numbers, -, and /. Because our slug source can contain numbers and dashes you can end up with a situation where dm-is-slug incorrectly interprets a slug as already in use.
An Example:
Assuming the following slug already exist:
Then if we attempt to create a new product with the SKU of F8Z469, we end up with a slug of f8z469-44, instead of the expected f8z469.
For us, I've been thinking the best approach might be to allow a config option that skips trying slug variations. Our slugs should always be unique, as the SKUs we generate them from should always be. If they aren't I'd rather just see a validation error that complains about the uniqueness of the slug.
Whether this will work for everyone, I'm not sure :-)
The text was updated successfully, but these errors were encountered: