imageCredentials.name value for Kube-Enforcer Chart discrepancy

[JakeMeloche]

the imageCredentials.name value should be aqua-registry-secret not aqua-registry.

https://github.com/aquasecurity/aqua-helm/blob/2022.4/kube-enforcer/values.yaml#L35C4-L35C26

[semyonmor]

@JakeMeloche why?

[spimmer]

@semyonmor Because Documentation instructs to create the pull secret with name aqua-registry-secret:

aqua-helm/docs/imagepullsecret.md

Line 14 in 1ab4748

kubectl create secret docker-registry aqua-registry-secret --docker-server="registry.aquasec.com" --namespace aqua --docker-username="[email protected]" --docker-password="<Password>" --docker-email="[email protected]"

Furthermore the default value is aqua-registry-secret in the helpers file:

aqua-helm/kube-enforcer/templates/_helpers.tpl

Line 54 in 1ab4748

{{ .Values.global.imageCredentials.name | default (printf "aqua-registry-secret") }}

So to me it makes sense to use this de facto standard name in the values.yamltoo:

aqua-helm/kube-enforcer/values.yaml

Line 38 in 1ab4748

name: "aqua-registry"