Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): handle null properties in CloudFormation templates #7809

Closed
nikpivkin opened this issue Oct 29, 2024 · 0 comments · Fixed by #7813
Closed

fix(misconf): handle null properties in CloudFormation templates #7809

nikpivkin opened this issue Oct 29, 2024 · 0 comments · Fixed by #7813
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. scan/misconfiguration Issues relating to misconfiguration scanning
Milestone

Comments

@nikpivkin
Copy link
Contributor

Template analysis stops if there is at least one null property in the template. Trivy must handle such properties correctly.

Template:

AWSTemplateFormatVersion: "2010-09-09"
Resources:
  TestBucket:
    Type: "AWS::S3::Bucket"
    Properties:
      BucketName:

Output:

2024-10-29T11:18:20+06:00       ERROR   [cloudformation parser] Error parsing file      file_path="main.yaml" err="panic during parse: runtime error: invalid memory address or nil pointer dereference"
@nikpivkin nikpivkin added kind/bug Categorizes issue or PR as related to a bug. scan/misconfiguration Issues relating to misconfiguration scanning labels Oct 29, 2024
@nikpivkin nikpivkin self-assigned this Oct 29, 2024
@simar7 simar7 added this to the v0.58.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. scan/misconfiguration Issues relating to misconfiguration scanning
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants
@simar7 @nikpivkin and others