Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(k8s): add v prefix for Go packages #7822

Open
DmitriyLewen opened this issue Oct 30, 2024 · 0 comments · May be fixed by #7839
Open

refactor(k8s): add v prefix for Go packages #7822

DmitriyLewen opened this issue Oct 30, 2024 · 0 comments · May be fixed by #7839
Assignees
Labels
target/kubernetes Issues relating to kubernetes cluster scanning
Milestone

Comments

@DmitriyLewen
Copy link
Contributor

Description

Gobinary packages have v prefix.
We removed v prefix truncation for gomod packages (see #7733).

But Go packages obtained from k8s scanner don't have v prefix:

{
Type: core.TypeApplication,
Name: "github.com/containerd/containerd",
Version: "1.5.2",
Properties: []core.Property{
{
Name: k8sComponentName,
Value: "github.com/containerd/containerd",
Namespace: k8sCoreComponentNamespace,
},
{
Name: k8sComponentType,
Value: "node",
Namespace: k8sCoreComponentNamespace,
},
},
PkgIdentifier: ftypes.PkgIdentifier{
PURL: &packageurl.PackageURL{
Type: "golang",
Name: "github.com/containerd/containerd",
Version: "1.5.2",
Qualifiers: packageurl.Qualifiers{},
},
BOMRef: "pkg:golang/github.com%2Fcontainerd%[email protected]",
},
},

We need to add it.

@afdesk afdesk self-assigned this Oct 30, 2024
@afdesk afdesk linked a pull request Oct 31, 2024 that will close this issue
6 tasks
@knqyf263 knqyf263 added this to the v0.58.0 milestone Oct 31, 2024
@knqyf263 knqyf263 added the target/kubernetes Issues relating to kubernetes cluster scanning label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/kubernetes Issues relating to kubernetes cluster scanning
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants