Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with_rotation_offset and apply_offset are completely incomplete! #89

Open
arafune opened this issue Dec 28, 2024 · 0 comments
Open

with_rotation_offset and apply_offset are completely incomplete! #89

arafune opened this issue Dec 28, 2024 · 0 comments

Comments

@arafune
Copy link
Owner

arafune commented Dec 28, 2024

Consider removing apply_offset ? I have already prepared corrected_coords
Before converting to momentum space, we must sometime take care the beta and theta those are not "offset" angle. Considering this, I don't think apply_offset is suitable name.
.
And then I should consider with_rotation_offset by using corrected_cooreds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant