-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent, Finance: token balances module doesn't live update #1062
Comments
Hmm, this is quite awkward and shouldn't be the case. Maybe there's something weird with how we're memoizing but the balances should definitely be updating. |
@rperez89 Now I'm suspecting this may be due to race conditions with the underlying ETH node (e.g. we got the event first, but then when we did the balance update via an Here's what I would do to fix this:
This also has the nice side-effect of catching updates for any "hidden" transfers (e.g. directly sending tokens to the Agent / Vault). Note that we should also apply this same trick to the Agent app. |
ahh about that nice side effect that you are talking about, i did exactly that to test i sent eth directly to the vault. |
This also happens if you deploy a token, mint, approve and deposit in the same transaction. The tokens appear in the transfer ledger, but the withdraw is not possible. This isn't fixed on a hard refresh. @sohkai How should I send an API request to force a refresh? Currently testing on Rinkeby. |
I just did an ANT deposit into an org while Finance was open. As soon as the transaction was mined, the transfer appeared in the transfer ledger, but the balance on top didn't update until I forced a refresh
Before refreshing (as soon as the deposit was mined):
After reloading the app:
The text was updated successfully, but these errors were encountered: