Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent: ensure approval state doesn't change in safeExecute()? #1072

Closed
sohkai opened this issue Jan 22, 2020 · 1 comment
Closed

Agent: ensure approval state doesn't change in safeExecute()? #1072

sohkai opened this issue Jan 22, 2020 · 1 comment

Comments

@sohkai
Copy link
Contributor

sohkai commented Jan 22, 2020

Note: this has been closed to be tracked in the "wishlist for future upgrades".

cc @izqui @osarrouy.

Currently safeExecute() only disallows token transfers, but users can still change a token's approval amount. Given that changing this amount can lead to unwanted / unpermitted token transfers at a later time, should we also ensure in the safeExecute() loop that token approval amounts haven't changed?

@sohkai
Copy link
Contributor Author

sohkai commented Mar 18, 2020

Closing for now; we can evaluate in future versions of Agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant