Fixed issue with apm packages command #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Congrats on merging your first pull request! Aragon is proud of you 🦅 |
c0rv0s
pushed a commit
that referenced
this pull request
Mar 16, 2021
* Fixed issue with apm packages command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦅 Pull Request Description
This PR is related to #1824 and does get merged into the QA PR called
issue-1050/update-testsRational
The
packages objectwas returningnameandversionproperties, before the fix the table was trying to fetch arepoproperty that wasn't being returned by the object and this was causing the error.✔️ PR Todo
This command (
aragon apm packages) is still failing on Rinkeby. This is another issue that has to be fixed by someone with access to the aragonpm.eth registry: #1824 (comment)