Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper: merge AppProxy's ABI into app's ABI if we know app is a proxy #423

Open
sohkai opened this issue Jan 31, 2020 · 0 comments
Open

Wrapper: merge AppProxy's ABI into app's ABI if we know app is a proxy #423

sohkai opened this issue Jan 31, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@sohkai
Copy link
Contributor

sohkai commented Jan 31, 2020

See original comments in aragon/aragon-cli#659.

Rather than doing this at "build" time, it makes more sense to do at run time, when we can check whether or not the app is actually a proxy (checking implementation()).

We may also want to add an isProxy flag to the app object to help others distinguish if it is a proxy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sohkai