From e855a07a0a05c75dd09008d84c2cc5b03df446de Mon Sep 17 00:00:00 2001 From: Michael Heuer Date: Fri, 26 Jan 2024 11:10:23 +0100 Subject: [PATCH 1/3] fix: wrong import path --- packages/contracts/hardhat.config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/contracts/hardhat.config.ts b/packages/contracts/hardhat.config.ts index b2cdc5fb6..f4045e281 100644 --- a/packages/contracts/hardhat.config.ts +++ b/packages/contracts/hardhat.config.ts @@ -1,5 +1,5 @@ import networks, {ContractsNetworkConfig} from './networks'; -import {AragonPluginRepos, TestingFork} from './utils/types'; +import {AragonPluginRepos, TestingFork} from './types/hardhat'; import {NetworkConfigs} from '@aragon/osx-commons-configs'; import '@nomicfoundation/hardhat-chai-matchers'; import '@nomicfoundation/hardhat-network-helpers'; From b2a3f9ec254810fb31999225d42d52c2d427a3a9 Mon Sep 17 00:00:00 2001 From: Michael Heuer Date: Mon, 29 Jan 2024 16:42:20 +0100 Subject: [PATCH 2/3] docs: wrong NatSpec --- .../src/framework/plugin/setup/PluginSetupProcessor.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/contracts/src/framework/plugin/setup/PluginSetupProcessor.sol b/packages/contracts/src/framework/plugin/setup/PluginSetupProcessor.sol index 50e04f9a7..88ddd92e0 100644 --- a/packages/contracts/src/framework/plugin/setup/PluginSetupProcessor.sol +++ b/packages/contracts/src/framework/plugin/setup/PluginSetupProcessor.sol @@ -498,7 +498,7 @@ contract PluginSetupProcessor is ProtocolVersion { /// @notice Applies the permissions of a prepared update of an UUPS upgradeable proxy contract to a DAO. /// @param _dao The address of the updating DAO. - /// @param _params The struct containing the parameters for the `applyInstallation` function. + /// @param _params The struct containing the parameters for the `applyUpdate` function. function applyUpdate( address _dao, ApplyUpdateParams calldata _params From 4da10d4d8b0d39fc92773e36bdf5413bec103f5c Mon Sep 17 00:00:00 2001 From: Michael Heuer Date: Wed, 31 Jan 2024 12:31:38 +0100 Subject: [PATCH 3/3] fix: missing await --- .../test/framework/utils/ens/ens-subdomain-registry.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/contracts/test/framework/utils/ens/ens-subdomain-registry.ts b/packages/contracts/test/framework/utils/ens/ens-subdomain-registry.ts index 490c32ebc..7c4fb060b 100644 --- a/packages/contracts/test/framework/utils/ens/ens-subdomain-registry.ts +++ b/packages/contracts/test/framework/utils/ens/ens-subdomain-registry.ts @@ -231,7 +231,7 @@ describe('ENSSubdomainRegistrar', function () { it('reverts if the approval of the registrar is removed', async () => { // Initialize the registrar with the 'test' domain - registrar.initialize( + await registrar.initialize( managingDao.address, ens.address, ensDomainHash('test')