From 90a24566d55a0a09b87e9f05a21d9c4822ec9744 Mon Sep 17 00:00:00 2001 From: jordaniza Date: Tue, 20 Feb 2024 12:08:06 +0400 Subject: [PATCH] fix typo in fallback value --- packages/contracts/test/deploy/default-env.ts | 6 +++--- packages/contracts/utils/environment.ts | 6 +++++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/contracts/test/deploy/default-env.ts b/packages/contracts/test/deploy/default-env.ts index f244c67a0..8b072e377 100644 --- a/packages/contracts/test/deploy/default-env.ts +++ b/packages/contracts/test/deploy/default-env.ts @@ -50,7 +50,7 @@ describe('detect network', () => { it('sets the correct fallbacks for each environment variable', () => { expect(daoDomainEnv(network)).to.equal('dao.eth'); - expect(pluginDomainEnv(network)).to.equal('plugin.eth'); + expect(pluginDomainEnv(network)).to.equal('plugin.dao.eth'); expect(managementDaoSubdomainEnv(network)).to.equal('management'); expect(managementDaoMultisigApproversEnv(network)).to.equal( HARDHAT_ACCOUNTS[0].ADDRESS @@ -63,8 +63,8 @@ describe('detect network', () => { it('string interpolates the ENS subdomains', () => { const network: Network = {name: 'FakeNet'} as unknown as Network; process.env['FAKENET_DAO_ENS_DOMAIN'] = 'mydao.eth'; - process.env['FAKENET_PLUGIN_ENS_DOMAIN'] = 'myplugin.eth'; + process.env['FAKENET_PLUGIN_ENS_DOMAIN'] = 'myplugin.dao.eth'; expect(daoDomainEnv(network)).to.equal('mydao.eth'); - expect(pluginDomainEnv(network)).to.equal('myplugin.eth'); + expect(pluginDomainEnv(network)).to.equal('myplugin.dao.eth'); }); }); diff --git a/packages/contracts/utils/environment.ts b/packages/contracts/utils/environment.ts index 8d1602328..e9e862ff3 100644 --- a/packages/contracts/utils/environment.ts +++ b/packages/contracts/utils/environment.ts @@ -42,7 +42,11 @@ export const daoDomainEnv = (network: Network): string => env(network, `${network.name.toUpperCase()}_DAO_ENS_DOMAIN`, 'dao.eth'); export const pluginDomainEnv = (network: Network): string => - env(network, `${network.name.toUpperCase()}_PLUGIN_ENS_DOMAIN`, 'plugin.eth'); + env( + network, + `${network.name.toUpperCase()}_PLUGIN_ENS_DOMAIN`, + 'plugin.dao.eth' + ); export const managementDaoSubdomainEnv = (network: Network): string => env(network, 'MANAGEMENT_DAO_SUBDOMAIN', 'management');