Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden component override resolution against edge case re: editable installs and INSTALLED_APPS order #11589

Open
jacobtylerwalls opened this issue Oct 30, 2024 · 0 comments
Labels
Type: Bug Something isn't working Webpack

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Oct 30, 2024

  • your ordered arches applications are FOO, BAR, BAZ
  • BAR and BAZ contain the component
  • FOO and BAR are installed in site-pacakges, but BAZ is installed with -e, so it gets a linked_application_path

Expect: bar component is found
Actual: baz component is found, because we iterate like this:

check FOO in site packages
     check all editable paths for all applications

so we find baz before continuing the loop to fin bar in site-packages. Granted I haven't set this up with to actually test, just seemed this way from a code read.

Originally posted by @jacobtylerwalls in #11562 (comment)

@jacobtylerwalls jacobtylerwalls added Type: Bug Something isn't working Webpack labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Webpack
Projects
Status: No status
Development

No branches or pull requests

1 participant