Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure coordinator node and cross validation nodes are different #980

Open
Neylix opened this issue Apr 17, 2023 · 0 comments · May be fixed by #1150
Open

Ensure coordinator node and cross validation nodes are different #980

Neylix opened this issue Apr 17, 2023 · 0 comments · May be fixed by #1150
Labels
enhancements mining Involve transaction validation and mining replication

Comments

@Neylix
Copy link
Member

Neylix commented Apr 17, 2023

Describe the problem you discovered

When a replication node verify the validation stamps and cross validation stamps signature, it does not ensure the coordinator node and the cross validation nodes are different.
This can be a breach for a malicious node to send a self signed transaction to storage nodes while it should be signed through the distributed workflow with multiple nodes.

Describe the solution you'd like

In the function Transaction.valid_stamps_signature? we should ensure the coordinator node is different from the cross validation nodes.
This check should be done only if the validation node list has at least 2 nodes

@Neylix Neylix added bug Something isn't working mining Involve transaction validation and mining replication labels Apr 17, 2023
@samuelmanzanera samuelmanzanera added this to the 1.2.0 milestone May 15, 2023
@samuelmanzanera samuelmanzanera added enhancements and removed bug Something isn't working labels May 15, 2023
@samuelmanzanera samuelmanzanera modified the milestones: 1.2.0, 1.3.0 May 15, 2023
@samuelmanzanera samuelmanzanera removed this from the 1.3.0 milestone Jul 3, 2023
@samuelmanzanera samuelmanzanera linked a pull request Jul 5, 2023 that will close this issue
@samuelmanzanera samuelmanzanera linked a pull request Jul 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements mining Involve transaction validation and mining replication
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants