Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Formatting /dev/sdX in ..." message if nothing will actually be formatted #2776

Open
trustytrojan opened this issue Nov 7, 2024 · 0 comments

Comments

@trustytrojan
Copy link

trustytrojan commented Nov 7, 2024

I got a scare when I saw the "Formatting in 5..." message even though I setup the partitions such that none of them said "create" or "modify" in the table shown by archinstall. I would definitely prefer that the message only be shown if anything will actually be formatted...

Here's the print statement of the "Formatting" message: https://github.com/archlinux/archinstall/blob/master/archinstall%2Flib%2Fdisk%2Ffilesystem.py#L49

And here's where partitions are filtered for "create" or "modify" partitions:
https://github.com/archlinux/archinstall/blob/master/archinstall%2Flib%2Fdisk%2Ffilesystem.py#L98-L99

This isn't a crucial issue but I feel it could prevent headaches for many users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant