Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo in shrable link dont work #50

Open
giovannidias1 opened this issue Apr 27, 2022 · 4 comments
Open

Demo in shrable link dont work #50

giovannidias1 opened this issue Apr 27, 2022 · 4 comments

Comments

@giovannidias1
Copy link

When i create a theme and try share this my changes in demo does not appear

Link

@arciisine
Copy link
Owner

arciisine commented Apr 27, 2022 via email

@giovannidias1
Copy link
Author

giovannidias1 commented Apr 28, 2022

When trying to copy the generated scss it also accuses errors between em and px

Error: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: 0.6666666667em and 16px have incompatible units.
    ╷
164 │   $wrapper-padding-bottom: ($subscript-margin-top + $line-height) * $subscript-font-scale;
    │                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵

from what I realized the problem is in the fonts specifically in the line-height

when i commented this line, worked fine

// headline: mat.define-typography-level(24px, 32px, 500, 'Montserrat', 0.0000em),

@giovannidias1
Copy link
Author

I found the problem, the problem is when you are setting values in Input, input does not support values in PX and EM, but it is possible to edit these values in the editor

@arciisine
Copy link
Owner

Thanks for rooting out the issue. I'll need to figure out if em/rem units are possible here, or if it only supports physical units (pt/px). Once I figure it out, I will update accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants