Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL of "IoT_Modules-Buttons" in repository list #3686

Merged

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Dec 1, 2023

Resubmission of #3672, which was closed without reason by the library maintainer and could not be reopened due to deletion of the head.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Hi @per1234.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

ERROR: Arduino Lint found errors with https://github.com/gq97a6/arduino_buttons:

Linting library in arduino_buttons
ERROR: Library name Buttons not found in the Library Manager index. Library names are not allowed to change after being 
       added to the index.                                                                                              
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: library.properties includes field item(s) buttons.h not found in library.                             
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: No readme found. Please document your library.                                                                                
         See:                                                                                                                          
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
         (Rule LD001)                                                                                                                  
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Linting sketch in arduino_buttons/examples/example

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 3 WARNINGS

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @per1234
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Dec 1, 2023
@per1234
Copy link
Contributor Author

per1234 commented Dec 1, 2023

ERROR: Library name Buttons not found in the Library Manager index. Library names are not allowed to change after being 
       added to the index.                                                                                              
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018) 

This error is not relevant to the URL change operation so this can be ignored.

Everyone is welcome to submit trivial URL updates, but name change requests can only be made by maintainers of the library. I have made strong efforts to communicate with the library maintainer about this so it is up to them to submit a name change request if they want to fix this problem.

@per1234 per1234 mentioned this pull request Dec 1, 2023
@MatteoPologruto MatteoPologruto self-assigned this Dec 6, 2023
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2023/12/06 17:07:11 Loaded 6428 libraries from DB
Changing URL of library IoT_Modules-Buttons from https://github.com/gq97a6/IoT_Modules-Buttons.git to https://github.com/gq97a6/arduino_buttons.git
Success!

@MatteoPologruto MatteoPologruto merged commit 51d50d1 into arduino:main Dec 6, 2023
12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Dec 6, 2023
@per1234 per1234 deleted the move-IoT_Modules-Buttons-repository branch December 16, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants