Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging SH2 commands to terminal using the tracer can result in a segfault #1733

Closed
remutro opened this issue Dec 28, 2024 · 1 comment · Fixed by #1734
Closed

Logging SH2 commands to terminal using the tracer can result in a segfault #1733

remutro opened this issue Dec 28, 2024 · 1 comment · Fixed by #1734

Comments

@remutro
Copy link
Contributor

remutro commented Dec 28, 2024

Describe the bug
Vic reported that logging SH2 commands to terminal using the tracer can result in a segfault. I was also able to reproduce this behavior. We were both on WinX64 using the latest available nightly. Vic mentioned he tried as far back as v137 and the problem was still present.

To Reproduce
Steps to reproduce the behavior:

  1. Open 32X ROM (I used latest Doom Resurrection, assuming Vic was working on his game)
  2. Open Tools > Tracer from the menu bar
  3. Click the log to terminal option for the two SH instruction options
  4. Wait for crash

Expected behavior
Instructions log to terminal correctly

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
This may be specific to the SH2 recompiler. It didn't crash for me using the interpreter but it is very slow and logs a ton of info so maybe I wasn't patient enough.

@invertego
Copy link
Contributor

invertego commented Dec 29, 2024

Thanks for writing this bug up, and to Vic for the initial report. For whatever it's worth, tracing never worked properly with the recompilers for any system before #1301. That PR should've made it work with all systems, but I must have overlooked 32x in my testing or neglected to retest after making additional changes before committing. In any case, it should be good after #1734 goes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants