Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-python/deployment] verify=False parameter is not passed to httpx.Client through Argilla class (v2.2.0) #5548

Open
xiajing10 opened this issue Sep 30, 2024 · 1 comment

Comments

@xiajing10
Copy link

Describe the bug
In Argilla version 2+, httpx.Client is created by rg.Argilla class. However, even though verify=False is added, still get Error ConnectError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate (_ssl.c:1000)

Stacktrace and Code to create the bug

import argilla as rg
client = rg.Argilla(api_url=<argilla_service_https_url>, api_key=<api_key>, verify=False)

Tried to test with create_http_client function

from argilla._api._http._client import create_http_client
client = create_http_client(api_url=<argilla_service_https_url>, api_key=<api_key>, verify=False)
print(client._transport._pool._ssl_context.verify_mode) 

output 2

Problem is from line

transport=httpx.HTTPTransport(retries=retries)

in create_http_client

After comment this line or add **client_args into httpx.HTTPTransport, output of print(client._transport._pool._ssl_context.verify_mode) turns to 0

Expected behavior
Connection to https url success with rg.Argilla(..., verify=False)

Environment:

  • Argilla Version 2.2.0:
  • ElasticSearch Version 8.5.3:
@xiajing10
Copy link
Author

Tested Argilla version 2.1.0 and verify=False works fine.

@xiajing10 xiajing10 changed the title [BUG-python/deployment] verify=False parameter is not passed to httpx.Client through Argilla class (v2) [BUG-python/deployment] verify=False parameter is not passed to httpx.Client through Argilla class (v2.2.0) Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant