Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring sycl backends in line with the Cpp Core Guidelines #13

Open
3 tasks
kris-rowe opened this issue Feb 2, 2023 · 0 comments
Open
3 tasks

Bring sycl backends in line with the Cpp Core Guidelines #13

kris-rowe opened this issue Feb 2, 2023 · 0 comments
Labels
clean-up Improvements to code quality (e.g. refactoring) sycl
Milestone
Sycl Backends Rev...

Comments

@kris-rowe
Copy link

Details

Todo

This list is not comprehensive

  • Use unnamed namespace instead of `static for local helper functions (F22)
  • Eliminate output parameters by returning in a tuple with the error flag (F21)
  • Add not_null where appropriate (F23)
@kris-rowe kris-rowe added sycl clean-up Improvements to code quality (e.g. refactoring) labels Feb 2, 2023
@kris-rowe kris-rowe added this to the Sycl-ref Backend milestone Feb 2, 2023
@kris-rowe kris-rowe changed the title Bring sycl-ref source in line with the Cpp Core Guidelines Bring sycl backends in line with the Cpp Core Guidelines Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clean-up Improvements to code quality (e.g. refactoring) sycl
Projects
None yet
Milestone
Sycl Backends Review and Clean-up
Development

No branches or pull requests
1 participant
@kris-rowe