Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying a specific argocd version with 'Repo bootstrap --app' is missing a patch #559

Open
AlexEndris opened this issue Feb 13, 2024 · 2 comments
Assignees

Comments

@AlexEndris
Copy link

AlexEndris commented Feb 13, 2024

As stated by @noam-codefresh here #557 (comment) the autopilot installation is missing a crucial patch in the kustomization.yaml resulting in a broken installation when using the --app flag for specifying an argocd version without referencing this repository's kustomization.yaml

As a side note: It would be good if the installation didn't reference this repository's /base or /ha kustomize folder in the first place to give more direct control over the version of argocd that is being used, if at all feasible.

@noam-codefresh noam-codefresh self-assigned this Feb 13, 2024
@noam-codefresh
Copy link
Collaborator

@AlexEndris

As a side note: It would be good if the installation didn't reference this repository's /base or /ha kustomize folder in the first place to give more direct control over the version of argocd that is being used, if at all feasible.
i am thinking about changing the installation process to just put the patches in the user's git repository, and then the reference will be explicit, and easy to manually upgrade.
and no more "passing" through the argocd-autopilot repository at all. wdyt?

@AlexEndris
Copy link
Author

All I can wish for! Thank you for being so quick about it! Very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants