You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When having more than one helm chart deployed in the same Application file, the annotation argocd-image-updater.argoproj.io/XXXX.helm.image-name does not update the properties for the correct chart, but for the first one. To Reproduce
Application.yaml
kind: Application
metadata:
name: name
namespace: namespace
annotations:
argocd-image-updater.argoproj.io/image-list: XXXXX=
argocd-image-updater.argoproj.io/XXXXX.platforms: linux/amd64
argocd-image-updater.argoproj.io/XXXXX.pull-secret: pullsecret:
argocd-image-updater.argoproj.io/XXXXX.update-strategy: semver
argocd-image-updater.argoproj.io/XXXXX.allow-tags: regexp:^[0-9]+
argocd-image-updater.argoproj.io/XXXXX.ignore-tags: latest
argocd-image-updater.argoproj.io/XXXXX.helm.image-tag: YYYY.image.tag #(YYYY should be the root yaml
property in the values file of chart 2)
argocd-image-updater.argoproj.io/XXXXX.helm.image-name: YYYY.image.repository
spec:
project:
sources:
- repoURL: ""
path: main
targetRevision: test
helm:
valueFiles:
- $values-chart1/path
- repoURL: ""
targetRevision: test
ref: values-chart1
- repoURL: ""
path: helm
targetRevision: test
helm:
valueFiles:
- $values-chart2/
- repoURL: ""
targetRevision: test
ref: values-chart2
destination:
server: "https://kubernetes.default.svc"
namespace: namespace
syncPolicy:
automated:
prune: true
selfHeal: true
Expected behavior
kind: Application
metadata:
name: name
namespace: namespace
annotations:
argocd-image-updater.argoproj.io/image-list: XXXXX=
argocd-image-updater.argoproj.io/XXXXX.platforms: linux/amd64
argocd-image-updater.argoproj.io/XXXXX.pull-secret: pullsecret:
argocd-image-updater.argoproj.io/XXXXX.update-strategy: semver
argocd-image-updater.argoproj.io/XXXXX.allow-tags: regexp:^[0-9]+
argocd-image-updater.argoproj.io/XXXXX.ignore-tags: latest
argocd-image-updater.argoproj.io/XXXXX.helm.image-tag: YYYY.image.tag #(YYYY should be the root
yaml property in the values file of chart 2)
argocd-image-updater.argoproj.io/XXXXX.helm.image-name: YYYY.image.repository
spec:
project:
sources:
- repoURL: ""
path: main
targetRevision: test
helm:
valueFiles:
- $values-chart1/path
# Actual property overwrite location
parameters:
- name: YYYY.image.repository
value: image
forceString: true
- name: YYYY.image.tag
value: '1'
forceString: true
- repoURL: ""
targetRevision: test
ref: values-chart1
- repoURL: ""
path: helm
targetRevision: test
helm:
valueFiles:
- $values-chart2/
# Expected property overwrite location
parameters:
- name: YYYY.image.repository
value: image
forceString: true
- name: YYYY.image.tag
value: '1'
forceString: true
- repoURL: ""
targetRevision: test
ref: values-chart2
destination:
server: "https://kubernetes.default.svc"
namespace: namespace
syncPolicy:
automated:
prune: true
selfHeal: true
Version
Chart version 0.11.0
Logs
The logs mentions that the properties are updated correctly and does not throw errors, but the place where the properties are updated is logically wrong
Additional-context
In the case above, we only had to swap chart-2 with chart-1 in the Application.yaml and it worked fine, since for chart-1 we don't need to use image updater. But in the cases where we have to update two images in two different values files which are in the same Application.yaml, this will not succeed. (Splitting the charts to different apps is a workaround ofcourse, but not always desired)
The text was updated successfully, but these errors were encountered:
Describe the bug
When having more than one helm chart deployed in the same Application file, the annotation
argocd-image-updater.argoproj.io/XXXX.helm.image-name
does not update the properties for the correct chart, but for the first one.To Reproduce
Application.yaml
Expected behavior
Version
Chart version 0.11.0
Logs
The logs mentions that the properties are updated correctly and does not throw errors, but the place where the properties are updated is logically wrong
Additional-context
In the case above, we only had to swap chart-2 with chart-1 in the Application.yaml and it worked fine, since for chart-1 we don't need to use image updater. But in the cases where we have to update two images in two different values files which are in the same Application.yaml, this will not succeed. (Splitting the charts to different apps is a workaround ofcourse, but not always desired)
The text was updated successfully, but these errors were encountered: