Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing host does not update ingress #558

Closed
ghost opened this issue Feb 11, 2022 · 3 comments · Fixed by #1553 · May be fixed by #699
Closed

Changing host does not update ingress #558

ghost opened this issue Feb 11, 2022 · 3 comments · Fixed by #1553 · May be fixed by #699
Labels
good first issue Good for newcomers help wanted Extra attention is needed triage:required

Comments

@ghost
Copy link

ghost commented Feb 11, 2022

Describe the bug
When setting up an ArgoCd, and later changing the host the ingress will not be updated with the new host information.

To Reproduce
Do a kubectl apply on something like:

apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: argocd
spec:
  server:
    ingress:
      enabled: true

followed by a kubectl apply on something like:

apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: argocd
spec:
  server:
    host: foo.bar

    ingress:
      enabled: true

then the host will still be set to the default value when describing the ingress

Expected behavior
That the ingress will be updated with the new host
@iam-veeramalla iam-veeramalla added good first issue Good for newcomers help wanted Extra attention is needed triage:required labels Feb 17, 2022
@renemifsud
Copy link

Is there any news on this please? Its a bit counter intuitive to have an operator but its still needed to alter the ingress directly after installation.

@mosuke5 mosuke5 mentioned this issue Jun 28, 2022
Open
2 tasks
@Elyytscha
Copy link
Contributor

@svghadi i think thats an issue that should be prioritized. we run into the same issue, additionally its possible that this behavior is at more places.

we deleted the ingress, so it got recreated with the new host, but it did not update other things related to that

like

  sso:
    dex:
      config: |
        connectors:
        - type: oidc
          id: keycloak
          name: keycloak
          config:
            issuer: https://sso.example.com/realms/MASTER
            redirectURI: https://argocd.example.com/api/dex/callback
            clientID: argocd.example.com

we changed clientID and redirectURI and the operator did not update those after we recreated the ingress (with deleting it and let the operator recreate it), so we couldn't login.

so i think the operator has in general issues with updating values when they get changed, imo we should look into that and maybe rework the update mechanism in general.

we ended up in just deleting the argocd custom resource itself and re applied it.

@svghadi
Copy link
Collaborator

svghadi commented Sep 24, 2024

Thanks @Elyytscha for highlighting the issue. @nmirasch is working on a fix for this.

@nmirasch nmirasch mentioned this issue Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed triage:required
Projects
None yet
Milestone
No milestone
4 participants
@Elyytscha @iam-veeramalla @renemifsud @svghadi