Does VolumeClaimGC is working ?

[Bfault]

I tried a
from hera.workflows.models.io.qrgoproj.workflow.v1alpha1 import VolumeClaimGC
but it doesn't seem to work

[flaviuvadan]

@Bfault any chance you can share an example? Some additional context would be helpful. Also, what's the Argo version?

[Bfault]

yeah sure I'm using it like

from hera.workflow import (
  Resource,
  Workflow,
  Container,
  Steps,
  Parameter,
  ExistingVolume,
  Env,
)

from hera.workflow.models,io.argoproj.workflow.v1alpha import VolumeClaimGC


VOLUME_CLAIM_MANIFEST = """
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: {{inputs.parameters.name}}-pvc
  namespace: {{inputs.parameters.namespace}}
spec:
  accessModes: {{inputs.parameters.access_modes}}
  resources:
    requests:
      storage: {{inputs.parameters.volume_claim_size}}
  volumeName: {{inputs.parameters.volume_name}}
  storageClassName: {{inputs.parameters.storage_class}}
"""


with Workflow(
  generate_name="train",
  entrypoint="training",
  volume_claim_gc=VolumeClaimGC(strategy="OnWorkflowCompletion"),
) as w:
  create_pvc = Resource(
    name="generate-pvc",
    action="create",
    manifest=VOLUME_CLAIM_MANIFEST ,
    inputs=[
      Parameter(name="name"),
      Parameter(name="namespace"),
      Parameter(name="storage_class", default="managed-csi-premium"),
      Parameter(name="volume_name"),
      Parameter(name="volume_size"),
      Parameter(name="access_modes", default='["ReadWriteOnce"]'),
    ],
    outputs=[
      {"name": "name", "valueFrom": {"jsonPath": "{.metadata.name}"}}
    ],
  )

  train = Container(
    name="train",
    image=...,
    command=...,
    args=...,
    volumes=[
      ExistingVolume(name="data", claim_name="{{inputs.parameters.data-pvc-name}}", mount_path="/root/data")
    ],
    env=[
      Env(name="ARGO_REMOVE_PVC_PROTECTION_FINALIZER", value="false")
    ],
  )
  with Steps(
    name="training",
  ) as s:
    data_pvc = create_pvc(
      name="create-data-pvc",
      arguments={
        "name": "training-921-data-pvc",
        "namespace": "argo",
        "volume_name": "',
        "volume_claim_size": "128Gi",
      },
    )
    
    train(arguments={
      "data-pvc-name": data_pvc.get_parameter("name"),
   } )

[tico24]

Just to point out the obvious… qrgoproj is not a word.

[Bfault]

sure my bqd typo when I write this question

[tico24]

In which case, we look forward to receiving more information so that we can help you.

[elliotgunton]

Hi @Bfault - could you add a new issue using this link and fill out all the details. We (and any other project) would need an actual description of the bug behaviour, a reproducible example, and details of your environment. Without these, we cannot help you.