Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary file access during archive extraction ("Zip Slip") #19710

Closed
McGon-Fid opened this issue Aug 28, 2024 · 1 comment
Closed

Arbitrary file access during archive extraction ("Zip Slip") #19710

McGon-Fid opened this issue Aug 28, 2024 · 1 comment
Labels
bug Something isn't working component:security

Comments

@McGon-Fid
Copy link

While working on argo I came across a codeql issue which can be addressed easily. It's a zip slip issue - details here:

codeql issue:
rule - go/zipslip
severity - error
level - high

Summary: Arbitrary file access during archive extraction ("Zip Slip")

Unsanitized archive entry, which may contain '..', is used in a file system operation.
Unsanitized archive entry, which may contain '..', is used in a file system operation.
Unsanitized archive entry, which may contain '..', is used in a file system operation.
@McGon-Fid McGon-Fid added the bug Something isn't working label Aug 28, 2024
@McGon-Fid McGon-Fid mentioned this issue Aug 28, 2024
Closed
@jsoref
Copy link
Member

jsoref commented Sep 25, 2024

I believe this is a false positive and I've filed github/codeql#17573 about it.

@jsoref jsoref closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component:security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: zip slip issue fidelity-contributions/argoproj-argo-cd
3 participants
@jsoref @pasha-codefresh @McGon-Fid