Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containers in pods with native sidecars don't show as "ready" #18725

Open
3 tasks done
adamwilner opened this issue Jun 18, 2024 · 5 comments · May be fixed by #19843
Open
3 tasks done

Containers in pods with native sidecars don't show as "ready" #18725

adamwilner opened this issue Jun 18, 2024 · 5 comments · May be fixed by #19843
Labels
bug Something isn't working component:cache component:kubernetes component:ui User interfaces bugs and enhancements

Comments

@adamwilner
Copy link

adamwilner commented Jun 18, 2024 •
edited
Loading

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug
In the tree view, pods with one or more native sidecars show all containers as not ready i.e. 0/2, even if they are.

To Reproduce
Define a Deployment with at least one container set up as a native sidecar and sync. When synced none of the containers in any of the resulting pods will appear ready.

Expected behavior
Pods in the tree view would show that containers are ready if they are.

Screenshots

Argocd
image

Kubectl
image

Version

v2.11.3+3f344d5

Logs

Paste any relevant application logs here.
@adamwilner adamwilner added the bug Something isn't working label Jun 18, 2024
@adamwilner adamwilner changed the title Containers in pods with native sidecars don't show as "ready" even if they are Containers in pods with native sidecars don't show as "ready" Jun 18, 2024
@booleanbetrayal
Copy link

Would love to have native sidecar support working in ArgoCD as that K8s feature would simplify a few things in our manifests. Wouldn't mind trying a stab at contributing either, but not sure the best place to start looking into this. Is this downstream of some healthcheck code, etc?

@agaudreault agaudreault added the component:ui User interfaces bugs and enhancements label Jun 22, 2024
@Hronom
Copy link
Contributor

Hronom commented Aug 20, 2024

Pretty important thing if you use popular service meshes like Istio. Otherwise it display wrong information.

@linghaoSu
Copy link
Contributor

could I take this?

@alexef
Copy link
Member

alexef commented Sep 6, 2024

go for it. here is the corresponding similar issue in Kubernetes Dashboard (with attached PR): kubernetes/dashboard#9299
checking where in ArgoCD code we have a similar logic

@alexef
Copy link
Member

alexef commented Sep 6, 2024

this is actually here: https://github.com/argoproj/argo-cd/blob/master/controller/cache/info.go#L310 @linghaoSu let me know if you need help with the PR

@linghaoSu linghaoSu linked a pull request Sep 9, 2024 that will close this issue
Draft
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component:cache component:kubernetes component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(controller): fix pod with sidercar state linghaoSu/argo-cd
6 participants
@alexef @Hronom @booleanbetrayal @agaudreault @linghaoSu @adamwilner