Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forks to opt-in for codeql #19993

Closed
jsoref opened this issue Sep 18, 2024 · 1 comment · Fixed by #19996
Closed

Allow forks to opt-in for codeql #19993

jsoref opened this issue Sep 18, 2024 · 1 comment · Fixed by #19996
Labels
component:ci enhancement New feature or request

Comments

@jsoref
Copy link
Member

jsoref commented Sep 18, 2024

Summary

#7832 disabled running codeql and a number of other workflows in forks. This isn't terrible, but it isn't ideal. (The average repository was definitely wasting cycles, and changing the behavior saves all those cycles.)

Motivation

There are a handful of "CodeQL" "triggered" "pull requests" at the moment. It'd be handy if I could set a variable in my fork to enable using CodeQL. It would be off by default for any forks that don't have the variable defined, but it would be a lot cleaner than users having to commit to master just to run codeql in forks.

Proposal

Change this line (note, this is not the line as it exists on master, it's the line present in my fork as I had to change it in order to trigger CodeQL, the only difference being a leading #):

# if: github.repository == 'argoproj/argo-cd'

To

if: github.repository == 'argoproj/argo-cd' || vars.enable_codeql

(Eventually enable_codeql could be set as a var in the argoproj/argo-cd repository, and the first half of the if could be removed.)

@jsoref jsoref added the enhancement New feature or request label Sep 18, 2024
@terrytangyuan
Copy link
Member

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants