Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top level Dark Mode should set the default for logs to dark mode #21426

Open
3 tasks done
jsoref opened this issue Jan 8, 2025 · 3 comments · May be fixed by #21448
Open
3 tasks done

Top level Dark Mode should set the default for logs to dark mode #21426

jsoref opened this issue Jan 8, 2025 · 3 comments · May be fixed by #21448
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@jsoref
Copy link
Member

jsoref commented Jan 8, 2025

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Changing the top level appearance to dark mode doesn't change the log view to dark mode

To Reproduce

  1. Visit https://cd.apps.argoproj.io/settings/appearance
  2. Select the Enable button (or do nothing if you see Disable)
  3. Visit https://cd.apps.argoproj.io/applications/argocd/argo-cd?resource=&view=pods&podSortMode=topLevelResource&node=apps%2FStatefulSet%2Fargocd%2Fargocd-redis-ha-server%2F0&tab=logs

Expected behavior

Dark mode logs with the option to click the highlighted moon to turn off dark mode for logs (if i want to hurt my eyes)

Dark mode with dark logs view with an option to disable dark logs

Screenshots

Dark mode with light logs view that hurts my eyes

Version

{
    "Version": "v2.14.0+9ac1670",
    "BuildDate": "2024-09-20T15:20:28Z",
    "GitCommit": "9ac1670c91c8829543725f9387535e201bd6e05e",
    "GitTreeState": "clean",
    "GoVersion": "go1.23.1",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v5.4.3 2024-07-19T16:40:33Z",
    "HelmVersion": "v3.15.2+g1a500d5",
    "KubectlVersion": "v0.31.0",
    "JsonnetVersion": "v0.20.0"
}

Logs

@jsoref jsoref added the bug Something isn't working label Jan 8, 2025
@surajyadav1108
Copy link
Contributor

surajyadav1108 commented Jan 9, 2025

🤔 I think I implemented this before as part of a Multiple Dark Mode Enhancements PR but later reverted this particular change based on a suggestion from @keithchong. We discussed this in these two PRs and decided to keep it the way it is now.

pod log view dark mode toggle #18424
Dark-mode-enhancements #17241

@jsoref
Copy link
Member Author

jsoref commented Jan 9, 2025

I'm pretty comfortable saying that top level dark mode should be efficiently a distinct profile:

Switching to dark mode should default to its log viewer default setting (dark mode). Once someone sets the log viewer to light from dark mode, that should be remembered for dark mode.

Similarly, if one switches the top level mode back to light mode, the persisted preference for pod log color in light mode should be used, not the view selected while in dark mode.

@surajyadav1108 surajyadav1108 linked a pull request Jan 10, 2025 that will close this issue
14 tasks
@surajyadav1108
Copy link
Contributor

@jsoref I have put up the profile for log-viewer.

@agaudreault agaudreault added the component:ui User interfaces bugs and enhancements label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants