Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] argo-rollouts should restart when changes are made to the configmap #3118

Open
DerekTBrown opened this issue Jan 10, 2025 · 0 comments · May be fixed by #3119
Open

[feat] argo-rollouts should restart when changes are made to the configmap #3118

DerekTBrown opened this issue Jan 10, 2025 · 0 comments · May be fixed by #3119
Labels
argo-rollouts enhancement New feature or request

Comments

@DerekTBrown
Copy link

Is your feature request related to a problem?

  • The argo-rollouts-config ConfigMap contains various options that can only be modified upon pod restart.
  • Currently, changing the ConfigMap does not trigger a pod restart.
  • This is problematic for a number of reasons:
    1. A user needs to manually churn all of the pods for changes to take effect, which is cumbersome.
    2. If the user introduces a bad change, and forgets to manually churn all the pods, this becomes a ticking time-bomb, since the changes will take effect when the pods next restart of their own accord

Related helm chart

argo-rollouts

Describe the solution you'd like

The idiomatic solution is to include a hash of the ConfigMap as part of the Deployment spec. Thus, if the ConfigMap changes, the Deployment will automatically be updated.

Describe alternatives you've considered

No response

Additional context

No response

@DerekTBrown DerekTBrown added the enhancement New feature or request label Jan 10, 2025
@DerekTBrown DerekTBrown linked a pull request Jan 10, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-rollouts enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants