Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the yaml of Store Oauth access token in argo-rollouts-notification-secret secret doc #3942

Open
2 tasks
chansuke opened this issue Nov 14, 2024 · 0 comments · May be fixed by #3943
Open
2 tasks

Correct the yaml of Store Oauth access token in argo-rollouts-notification-secret secret doc #3942

chansuke opened this issue Nov 14, 2024 · 0 comments · May be fixed by #3943
Labels
bug Something isn't working docs Needs documentation/release notes

Comments

@chansuke
Copy link
Contributor

Checklist:

  • I've included steps to reproduce the bug.
  • I've included the version of argo rollouts.

Describe the bug

While reading the Slack integration documentation, I noticed a potential issue with the example YAML.
The secret's name seems to be incorrectly specified in the documentation.

In the YAML snippet, the name field is shown as "secret-name". However, it should be argo-rollouts-notification-secret?

  apiVersion: v1
  kind: Secret
  metadata:
      name: <secret-name> // It should be `argo-rollouts-notification-secret` ?
  stringData:
      slack-token: <Oauth-access-token>

Reference: source code

To Reproduce

Expected behavior

Screenshots

Version

Logs

# Paste the logs from the rollout controller

# Logs for the entire controller:
kubectl logs -n argo-rollouts deployment/argo-rollouts

# Logs for a specific rollout:
kubectl logs -n argo-rollouts deployment/argo-rollouts | grep rollout=<ROLLOUTNAME

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@chansuke chansuke added the bug Something isn't working label Nov 14, 2024
@kostis-codefresh kostis-codefresh added the docs Needs documentation/release notes label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Needs documentation/release notes
Projects
None yet
2 participants