Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply workflowMetadata before workflow Create #10138

Open
kostas-theo opened this issue Nov 29, 2022 · 1 comment
Open

Apply workflowMetadata before workflow Create #10138

kostas-theo opened this issue Nov 29, 2022 · 1 comment
Labels
type/feature Feature request

Comments

@kostas-theo
Copy link
Contributor

Summary

I can submit a workflow using a WorkflowTemplate and I can ensure my workflow has the correct annotations / labels using spec.workflowMetadata. Upon submitting, the Workflow resource is initially created WITHOUT my required metadata. The controller then updates my workflow's metadata to include what was specified in my template in workflowMetadata.

I propose using the SubmitOpts, or some new configuration to set any static workflow metadata at creation time.

Optionally, it might also be a good idea to show in the UI (SubmitWorkflowPanel), what labels are set in the spec.workflowMetadata field.

Use Cases

We are currently using gatekeeper to enforce labels for all workflows to get more precise metrics. This uses an admission webhook to stop users from creating workflows which don't have required labels. As the required labels are NOT PRESENT at creation time, we cannot enforce any labels.


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@kostas-theo kostas-theo added the type/feature Feature request label Nov 29, 2022
@tooptoop4
Copy link
Contributor

func (woc *wfOperationCtx) updateWorkflowMetadata() error {
is the section, i wonder if this issue causes #12167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants