Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.5 Pagination in workflow list page not working #13090

Closed
3 of 4 tasks
kangyanzhou opened this issue May 24, 2024 · 5 comments
Closed
3 of 4 tasks

3.5 Pagination in workflow list page not working #13090

kangyanzhou opened this issue May 24, 2024 · 5 comments
Labels
area/api Argo Server API area/server area/workflow-archive solution/duplicate This issue or PR is a duplicate of an existing one type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@kangyanzhou
Copy link

kangyanzhou commented May 24, 2024

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

We have about 10k+ archived workflows in the dev database, and I'm trying to upgrade from v3.4.10 to v3.5.6.

After the upgrade the next page button in the workflow page is disabled with warning Workflows cannot be globally sorted when paginated. The only way for me to view more workflows is to choose a larger limit. Is there a new setting I need to apply in v3.5?

Version

v3.5.6

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

N/A

Logs from the workflow controller

N/A

Logs from in your workflow's wait container

N/A
@kangyanzhou
Copy link
Author

The argo server log has no error, although I can constantly see warnings regarding slow query.

@agilgur5
Copy link
Member

Likely a duplicate of #11715, which should be resolved in 3.5.7, which I was hoping to release this weekend

@agilgur5 agilgur5 added type/regression Regression from previous behavior (a specific type of bug) area/api Argo Server API area/workflow-archive area/server solution/duplicate This issue or PR is a duplicate of an existing one labels May 25, 2024
@kangyanzhou
Copy link
Author

Likely a duplicate of #11715, which should be resolved in 3.5.7, which I was hoping to release this weekend

Thanks!

@agilgur5 agilgur5 added this to the v3.5.x patches milestone May 27, 2024
@agilgur5
Copy link
Member

agilgur5 commented May 28, 2024

v3.5.7 is released, which contains a backport of #12736 / #13021 that fixed #11715.

Please try it out and let us know if it's fixed now.

@kangyanzhou
Copy link
Author

Yes it's fixed now. Thanks!

@agilgur5 agilgur5 changed the title Pagination in the workflow page is disabled 3.5 Pagination in workflow list page not working May 30, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api Argo Server API area/server area/workflow-archive solution/duplicate This issue or PR is a duplicate of an existing one type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

No branches or pull requests

2 participants