build: fix Makefile dependencies for zz_generated.deepcopy.go to include code-generator which it uses
#13647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Clucas <[email protected]>
Joibel
changed the title
Makefile dependencies for zz_generated.deepcopy.go to include code-generator which it uses
blkperl
approved these changes
Sep 23, 2024
|
FYI: #13660 should fix the flaky test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'd like to be able to
make <whatever>and it just work.$(GOPATH)/pkg/mod/k8s.io/[email protected]/generate-groups.shis created as part of installing go-to-protobuf, but this is not a dependency ofpkg/apis/workflow/v1alpha1/zz_generated.deepcopy.gowhich usesgenerate-groups.shIf I change the version of code-generator in use I get
Modification
I have added this as a direct dependency. We could have a make target of
$(GOPATH)/pkg/mod/k8s.io/[email protected]/generate-groups.shwhich might make things clearer, but I'm unconvinced it does, so I did the smaller change.Verification
If I change the version of code-generator we use and install it will now do a rebuild
zz_generated.deepcopy.gocorrectly.