ci: improve performance by eliminating redundancies

[MasonM]

Motivation

There's three sources of redundancy that are slowing down CI builds:

1. make install is being redundantly run three times for each E2E test:
   1. In the workflow:

      argo-workflows/.github/workflows/ci-build.yaml

      Lines 349 to 350 in 6699ab3

      	- name: Install manifests
      	run: make install PROFILE=${{matrix.profile}} STATIC_FILES=false

   2. As a prerequisite of make start:

      argo-workflows/Makefile

      Line 547 in 6699ab3

      start: install controller kit

   3. As a dependency by Kit:

      argo-workflows/tasks.yaml

      Line 39 in 6699ab3

      dependencies: install build-controller port-forward

2. Similarly, the changes in ci: optimize tests by only building binaries once #14012 to centralize binary building aren't actually preventing the binaries from being rebuilt in the E2E tests because controller and cli are prerequisites of make start, and listed as prerequisites in Kit.
3. Go dependencies are being re-downloaded in every job. The actions/setup-go is supposed to prevent that by caching the contents of GOMODCACHE. I think the problem is the cache is usually populated by the docs workflow, which doesn't fetch all the Go dependencies (example), so they aren't included when actions/setup-go saves the cache.
   

Modifications

This eliminates the first two redundancies by removing the unnecessary prerequisites from the Makefile and the redundant make install step in ci-build.yaml. Also, I added make --touch dist/* to mark everything as up-to-date so the binaries aren't rebuilt (docs). For the issue with the go dependencies not being in the cache, I updated docs.yaml to run go mod download to ensure they're included.

Also, I consolidated Start controller/API and Wait for controller to be up steps so you can see everything Kit is doing in the logs for the former, which will help prevent these kind of oversights in the future. The reason I didn't catch the issue with binaries being rebuilt in #14012 is because the logs are discarded unless the build failed (in which case they were visible in the Failure debug - Controller/API logs step).

Verification

Wait for E2E tests

[MasonM]

/retest

[tczhao]

👍Would you have any metrics on how much performance this improves?

[MasonM]

@tczhao The first two redundancies impact the time for the "Start controller/API" step in the E2E test jobs. The new "Performance Metrics" page can show metrics for the E2E jobs as a whole, but it doesn't look at has step-level granularity. From a very quick look, it appears it reduces the time for that step by 2-3 minutes.

The third redundancy impacts everything Go-related, and the fix in this PR to avoid re-downloading Go dependencies isn't going to help with that until the cache is updated. I think it'll be 10-20 seconds.

[tczhao]

👍