fix: update upload-artifact and download-artifact #14070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
added
the
area/contributing
Signed-off-by: Alan Clucas <[email protected]>
Joibel
force-pushed
the
upload-download-artifact
branch
from
cb22fa1 to
1ba3eda
Compare
terrytangyuan
approved these changes
Jan 10, 2025
|
Thanks @terrytangyuan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12455
See also @agilgur5's commentary from #13027
Motivation
The github actions
upload-artifactanddownload-artifactare deprecated and will presumably stop working completely on the 30th of January 2025.Modifications
Update all uses of both actions to the latest releases by SHA, matching those introduced in #14012.
Remove the dependabot ignore for these actions so they get dependabot maintained.
Verification
This is a "github only" change so CI for this PR and future working or failing are the only mechanisms to check it works.
This PR fixes the warning we were getting - see this run for the PR: https://github.com/argoproj/argo-workflows/actions/runs/12706995546?pr=14070
Compare to a prior run: https://github.com/argoproj/argo-workflows/actions/runs/12703710249