Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact repository agnostic key-only artifacts #5001

Open
Bobgy opened this issue Feb 3, 2021 · 2 comments
Open

Artifact repository agnostic key-only artifacts #5001

Bobgy opened this issue Feb 3, 2021 · 2 comments
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc type/feature Feature request

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Feb 3, 2021

Summary

I was looking at the new key-only artifact support: #4618.
It looks awesome and very useful.

However, it seems to me that there's a missing piece. A workflow may use key-only artifacts like the example:
https://github.com/argoproj/argo/blob/master/examples/key-only-artifact.yaml

...
          artifacts:
          - name: file
            path: /mnt/file
            s3:
              key: my-file
...

However, the definition is still tied to s3. I think it helps if the definition can be artifact repository agnostic, for example

          artifacts:
          - name: file
            path: /mnt/file
            genericKey: my-file

Use Cases

The same workflow definition would be agnostic to choice of artifact repository store, it can be s3, gcs, oss, and maybe hdfs (if path is mapped to key).

Note, I do not have plans to use this feature yet, but it may making key-only artifacts more useful that I can consider in the future.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@Bobgy Bobgy added the type/feature Feature request label Feb 3, 2021
@alexec
Copy link
Contributor

alexec commented Feb 3, 2021

Nice idea. Would you like to submit a PR?

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 4, 2021

Thanks for confirming this makes sense to you too.

For my schedule, not yet right now. When I get to the point I need this in a short term, I will consider contributing it.

@alexec alexec added the area/artifacts S3/GCP/OSS/Git/HDFS etc label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants