From 46fba73ef0dbd7964a71ef3ac3b58e7e5bfe7741 Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Tue, 12 Mar 2024 18:40:17 -0400 Subject: [PATCH] chore(deps): use `docker/login-action` consistently instead of `Azure/docker-login` - `Azure/docker-login` seems to have been the first one to have been added in 6dc04b39c7986046c2be1535d2a933e4cba25e03, then `docker/login-action` was added after in c8eed1f23adcdb9dfd99c81e2ba1a053ab27d558, but it was not consistent - [`Azure/docker-login`](https://github.com/Azure/docker-login) is not maintained much, with the [last release](https://github.com/Azure/docker-login/releases/tag/v1.0.1) ~1.5 years ago and no update to Node v20 as of yet, despite issues and PRs on it from a few months ago - so use [`docker/login-action`](https://github.com/docker/login-action), which is more maintained, more centralized, more commonly used, and not on EoL Node - [last release](https://github.com/docker/login-action/releases/tag/v3.0.0) a few months ago, [last commit](https://github.com/docker/login-action/commit/566711b9b940f3a4aea3c883c1efeb76ab18c145) a few weeks ago Signed-off-by: Anton Gilgur --- .github/workflows/release.yaml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index ee5fc2a212c5..e656ba3eba0e 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -99,15 +99,15 @@ jobs: steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - name: Docker Login - uses: Azure/docker-login@83efeb77770c98b620c73055fbb59b2847e17dc0 # v1.0.1 + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 with: username: ${{ secrets.DOCKERIO_USERNAME }} password: ${{ secrets.DOCKERIO_PASSWORD }} - name: Login to Quay - uses: Azure/docker-login@83efeb77770c98b620c73055fbb59b2847e17dc0 # v1.0.1 + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 with: - login-server: quay.io + registry: quay.io username: ${{ secrets.QUAYIO_USERNAME }} password: ${{ secrets.QUAYIO_PASSWORD }} @@ -149,15 +149,15 @@ jobs: steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - name: Docker Login - uses: Azure/docker-login@83efeb77770c98b620c73055fbb59b2847e17dc0 # v1.0.1 + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 with: username: ${{ secrets.DOCKERIO_USERNAME }} password: ${{ secrets.DOCKERIO_PASSWORD }} - name: Login to Quay - uses: Azure/docker-login@83efeb77770c98b620c73055fbb59b2847e17dc0 # v1.0.1 + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 with: - login-server: quay.io + registry: quay.io username: ${{ secrets.QUAYIO_USERNAME }} password: ${{ secrets.QUAYIO_PASSWORD }} @@ -211,15 +211,15 @@ jobs: target: [ workflow-controller, argocli, argoexec ] steps: - name: Docker Login - uses: Azure/docker-login@83efeb77770c98b620c73055fbb59b2847e17dc0 # v1.0.1 + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 with: username: ${{ secrets.DOCKERIO_USERNAME }} password: ${{ secrets.DOCKERIO_PASSWORD }} - name: Login to Quay - uses: Azure/docker-login@83efeb77770c98b620c73055fbb59b2847e17dc0 # v1.0.1 + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 with: - login-server: quay.io + registry: quay.io username: ${{ secrets.QUAYIO_USERNAME }} password: ${{ secrets.QUAYIO_PASSWORD }} @@ -245,15 +245,15 @@ jobs: needs: [ push-images ] steps: - name: Docker Login - uses: Azure/docker-login@83efeb77770c98b620c73055fbb59b2847e17dc0 # v1.0.1 + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 with: username: ${{ secrets.DOCKERIO_USERNAME }} password: ${{ secrets.DOCKERIO_PASSWORD }} - name: Login to Quay - uses: Azure/docker-login@83efeb77770c98b620c73055fbb59b2847e17dc0 # v1.0.1 + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 with: - login-server: quay.io + registry: quay.io username: ${{ secrets.QUAYIO_USERNAME }} password: ${{ secrets.QUAYIO_PASSWORD }} - name: Try pulling