Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags extractor fails for tags which are substrings of other tags #10

Open
jakub-g opened this issue Jan 6, 2014 · 0 comments
Open

tags extractor fails for tags which are substrings of other tags #10

jakub-g opened this issue Jan 6, 2014 · 0 comments
Labels

Comments

@jakub-g
Copy link
Collaborator

jakub-g commented Jan 6, 2014

http://ariatemplates.com/usermanual/latest/filters

I guess the second snippet should display only onRequest and onResponse, without constructor:

430a17596704d3bb

When we look at the MD file:
https://raw.github.com/ariatemplates/usermanual/master/src/latest/core/advanced/filters.md

There are two calls to embed JS:

    <script src='http://snippets.ariatemplates.com/snippets/github.com/ariatemplates/documentation-code/snippets/core/filters/IoDelayFilter.js?tag=delayFilterConstructor&lang=javascript&outdent=true'></script>
    <script src='http://snippets.ariatemplates.com/snippets/github.com/ariatemplates/documentation-code/snippets/core/filters/IoDelayFilter.js?tag=delayFilter&lang=javascript&outdent=true'></script>

As we can see delayFilter is a substring of delayFilterConstructor.

Here's the input snippet:

https://github.com/ariatemplates/documentation-code/blob/master/snippets/core/filters/IoDelayFilter.js

So it seems that tags extractor matches not enough restrictively.

As a quick workaround, probably renaming the tags in both mentioned files would work, but it'd be better to fix it in the extractor code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant