New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Type Effectiveness for multiple types #2

Open

arirawr opened this issue Mar 13, 2020 · 0 comments

Labels

enhancement good first issue

Owner

arirawr commented Mar 13, 2020

Version 0.1.8 added type effectiveness, but it only calculates this for the first of a Pokemon's types.

For Pokemon with 2 types, it should be calculated as a combination of the 2.
e.g.

If type A take 2x damage from ice, and type B takes 2x damage from ice, type AB takes 4x damage.
If type A take 2x damage from ice, and type B takes 1/2 damage from ice, type AB takes 1x damage.

arirawr added enhancement good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment