Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine the Quickstart Guides into one #45

Merged
merged 20 commits into from
Oct 4, 2024
Merged

Combine the Quickstart Guides into one #45

merged 20 commits into from
Oct 4, 2024

Conversation

MitchV85
Copy link
Collaborator

@MitchV85 MitchV85 commented Oct 3, 2024 •
edited
Loading

Change Summary

  • Combine the acLabs Quickstart and Codespaces Quickstart guides into a single Quickstart guide.

Repository Checklist

  • My code has been rebased from the upstream main branch

JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
JulioPDX
JulioPDX reviewed Oct 3, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
MitchV85 and others added 12 commits October 3, 2024 19:55
@MitchV85 @JulioPDX
Update docs/quickstart.md
04389ce 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
08f48e9 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
2be9432 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
f471882 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
d5cca0e 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
ee7012a 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
3279d65 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
26144ed 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
fae3f19 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
c3daf47 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
8e62bbc 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 @JulioPDX
Update docs/quickstart.md
0f1b0f9 
Co-authored-by: JulioPDX <[email protected]>
@MitchV85 MitchV85 marked this pull request as ready for review October 4, 2024 00:49
ankudinov
ankudinov reviewed Oct 4, 2024
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
docs/quickstart.md Outdated Show resolved Hide resolved
docs/quickstart.md Outdated Show resolved Hide resolved
docs/quickstart.md Show resolved Hide resolved
docs/quickstart.md Outdated Show resolved Hide resolved
docs/quickstart.md Outdated Show resolved Hide resolved
docs/quickstart.md Show resolved Hide resolved
docs/quickstart.md Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
@ankudinov
Copy link
Contributor

And we absolutely need a section covering image download and import for users without tokens. Otherwise we'll cut some users, even if it's not applicable for TechLib case.

@MitchV85 MitchV85 merged commit ca96d82 into aristanetworks:main Oct 4, 2024
1 check passed
@MitchV85 MitchV85 deleted the quickstart-update branch October 4, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulioPDX JulioPDX JulioPDX left review comments

@ankudinov ankudinov ankudinov left review comments

@mthiel117 mthiel117 Awaiting requested review from mthiel117

@kpbush30 kpbush30 Awaiting requested review from kpbush30

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MitchV85 @ankudinov @JulioPDX