Inconsistent TCP MSS Ceiling Schema

[perimore]

Issue Summary

Inconsistency between ethernet_interfaces and tunnel_interfaces when configuring TCP MSS ceiling segment size.

ethernet_interfaces uses the below:

            ethernet_interfaces:
              - name: Ethernet10
                tcp_mss_ceiling:
                  ipv4_segment_size: 1500

Whereas tunnel_interfaces uses:

            tunnel_interfaces:
              - name: Tunnel1
                tcp_mss_ceiling:
                  ipv4: 1500

Rendering the same config:

interface Ethernet10
   switchport
   tcp mss ceiling ipv4 1500
!
interface Tunnel1
   tcp mss ceiling ipv4 1500

We would expect them both to use the same key. Considering support in ethernet_interfaces was implemented first, I would suggest using ipv4_segment_size

Which component(s) of AVD impacted

eos_cli_config_gen

How do you run AVD ?

PyAVD

Steps to reproduce

No response

Relevant log output

No response

Contributing Guide

• I agree to follow this project's Code of Conduct

[gmuloc]

This model is used in 4 places:

• ethernet_interfaces
• tunnel_interfaces
• dps_interfaces
• router_path_selection

two are using ipv4 / ipv6 and two are using ipv4_segment_size / ipv6_segment_size.

Following AVD spirit - we will keep ipv4 / ipv6.
The two places with ipvX_segment_size (namely ethernet_interfaces and router_path_selection) need to be added the new keys ipv4 and ipv6. The ipvX_segment_size keys will be deprecated and set to be removed in AVD 6.0.

eos_designs output needs to be updated to use the newer keys.