Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Pedersen CRH impl #73

Open
Pratyush opened this issue Sep 9, 2021 · 0 comments
Open

Refactor Pedersen CRH impl #73

Pratyush opened this issue Sep 9, 2021 · 0 comments
Assignees
Labels
D-medium Difficulty: medium P-medium Priority: medium T-refactor Type: cleanup/refactor

Comments

@Pratyush
Copy link
Member

Pratyush commented Sep 9, 2021

Right now, PedersenCRH impls CRH for any ProjectiveCurve, and outputs a group element. However, for TE curves, we can project this to just the x coordinate. Supporting this generically requires the hacky "InjectiveMap" infrastructure, so we should instead just impl CRH for PedersenCRH<SWCurve> which outputs a group element (maybe compressed?) and impl CRH for PedersenCRH<TECurve> which outputs the x coordinate, thus getting rid of the current hacks.

@Pratyush Pratyush added T-refactor Type: cleanup/refactor P-medium Priority: medium D-medium Difficulty: medium labels Sep 9, 2021
@Pratyush Pratyush self-assigned this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-medium Difficulty: medium P-medium Priority: medium T-refactor Type: cleanup/refactor
Projects
None yet
Development

No branches or pull requests

1 participant