New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially make `fields::nonnative::params` module private #80

Open

Pratyush opened this issue Aug 11, 2021 · 0 comments

Member

Pratyush commented Aug 11, 2021

params has been used somewhere else: https://github.com/arkworks-rs/sponge/blob/c9f7d24a5f10c415e9370a079cb060d95400b938/src/constraints/mod.rs#L19 (bits_le_to_nonnative) and https://github.com/arkworks-rs/crypto-primitives/blob/1a71386a10ef627834e4c3b14ca982811f23192d/src/snark/constraints.rs (NonNativeFieldInputVar).

We should move NonNativeFieldInputVar and bits_le_to_nonnative into r1cs-std, and the external world should just call them.

Originally posted by @weikengchen in #79 (comment)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment