From 59d353d7b81a89c8f9db42ab43c10c591d7c8e5a Mon Sep 17 00:00:00 2001 From: faithful91 Date: Wed, 9 Apr 2014 17:34:28 +0200 Subject: [PATCH] #19 #20 Config POM+Findbugs regles --- .../findbugs/findbugsXml.xml | 6 +++++ .../Findbugs_Config-Exclude_C2C.xml | 22 ++++++++++++++----- dcll.ctc.Parser/pom.xml | 17 +++++++++----- .../tsaap/questions/impl/DefaultAnswer.java | 6 ++--- workspacemechanic | 1 + 5 files changed, 39 insertions(+), 13 deletions(-) create mode 100644 dcll.ctc.Parser/${/Users/hazembradai/Documents/workspace-ggts-3.4.0.RELEASE/Parser-DCLL-CoffeeToCode}/findbugs/findbugsXml.xml create mode 160000 workspacemechanic diff --git a/dcll.ctc.Parser/${/Users/hazembradai/Documents/workspace-ggts-3.4.0.RELEASE/Parser-DCLL-CoffeeToCode}/findbugs/findbugsXml.xml b/dcll.ctc.Parser/${/Users/hazembradai/Documents/workspace-ggts-3.4.0.RELEASE/Parser-DCLL-CoffeeToCode}/findbugs/findbugsXml.xml new file mode 100644 index 0000000..8960775 --- /dev/null +++ b/dcll.ctc.Parser/${/Users/hazembradai/Documents/workspace-ggts-3.4.0.RELEASE/Parser-DCLL-CoffeeToCode}/findbugs/findbugsXml.xml @@ -0,0 +1,6 @@ + +/Users/hazembradai/Documents/workspace-ggts-3.4.0.RELEASE/Parser-DCLL-CoffeeToCode/dcll.ctc.Parser/target/classes/Users/hazembradai/.m2/repository/org/codehaus/mojo/findbugs-maven-plugin/2.5.2/findbugs-maven-plugin-2.5.2.jar/Users/hazembradai/.m2/repository/org/codehaus/gmaven/gmaven-mojo/1.4/gmaven-mojo-1.4.jar/Users/hazembradai/.m2/repository/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.4/gmaven-runtime-api-1.4.jar/Users/hazembradai/.m2/repository/org/codehaus/gmaven/feature/gmaven-feature-api/1.4/gmaven-feature-api-1.4.jar/Users/hazembradai/.m2/repository/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.4/gmaven-runtime-1.5-1.4.jar/Users/hazembradai/.m2/repository/org/codehaus/gmaven/feature/gmaven-feature-support/1.4/gmaven-feature-support-1.4.jar/Users/hazembradai/.m2/repository/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/hazembradai/.m2/repository/org/apache/ant/ant/1.8.2/ant-1.8.2.jar/Users/hazembradai/.m2/repository/org/apache/ant/ant-launcher/1.8.2/ant-launcher-1.8.2.jar/Users/hazembradai/.m2/repository/jline/jline/0.9.94/jline-0.9.94.jar/Users/hazembradai/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/hazembradai/.m2/repository/org/codehaus/gmaven/gmaven-plugin/1.4/gmaven-plugin-1.4.jar/Users/hazembradai/.m2/repository/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.4/gmaven-runtime-loader-1.4.jar/Users/hazembradai/.m2/repository/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.4/gmaven-runtime-support-1.4.jar/Users/hazembradai/.m2/repository/org/sonatype/gshell/gshell-io/2.4/gshell-io-2.4.jar/Users/hazembradai/.m2/repository/com/thoughtworks/qdox/qdox/1.12/qdox-1.12.jar/Users/hazembradai/.m2/repository/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/hazembradai/.m2/repository/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/hazembradai/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar/Users/hazembradai/.m2/repository/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/hazembradai/.m2/repository/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/hazembradai/.m2/repository/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/hazembradai/.m2/repository/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/hazembradai/.m2/repository/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/hazembradai/.m2/repository/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/hazembradai/.m2/repository/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/hazembradai/.m2/repository/oro/oro/2.0.8/oro-2.0.8.jar/Users/hazembradai/.m2/repository/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/hazembradai/.m2/repository/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/hazembradai/.m2/repository/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/hazembradai/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/hazembradai/.m2/repository/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/hazembradai/.m2/repository/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/hazembradai/.m2/repository/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/hazembradai/.m2/repository/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/hazembradai/.m2/repository/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/hazembradai/.m2/repository/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/hazembradai/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/hazembradai/.m2/repository/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/hazembradai/.m2/repository/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/hazembradai/.m2/repository/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/hazembradai/.m2/repository/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/hazembradai/.m2/repository/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/hazembradai/.m2/repository/com/google/code/findbugs/findbugs-ant/2.0.1/findbugs-ant-2.0.1.jar/Users/hazembradai/.m2/repository/com/google/code/findbugs/findbugs/2.0.1/findbugs-2.0.1.jar/Users/hazembradai/.m2/repository/com/google/code/findbugs/bcel/2.0.1/bcel-2.0.1.jar/Users/hazembradai/.m2/repository/com/google/code/findbugs/jsr305/2.0.1/jsr305-2.0.1.jar/Users/hazembradai/.m2/repository/com/google/code/findbugs/jFormatString/2.0.1/jFormatString-2.0.1.jar/Users/hazembradai/.m2/repository/com/google/code/findbugs/annotations/2.0.1/annotations-2.0.1.jar/Users/hazembradai/.m2/repository/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/hazembradai/.m2/repository/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/hazembradai/.m2/repository/jdom/jdom/1.0/jdom-1.0.jar/Users/hazembradai/.m2/repository/xom/xom/1.0/xom-1.0.jar/Users/hazembradai/.m2/repository/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/hazembradai/.m2/repository/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/hazembradai/.m2/repository/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/hazembradai/.m2/repository/asm/asm/3.3/asm-3.3.jar/Users/hazembradai/.m2/repository/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/hazembradai/.m2/repository/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/hazembradai/.m2/repository/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/hazembradai/.m2/repository/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/hazembradai/.m2/repository/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/hazembradai/.m2/repository/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/hazembradai/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar/Users/hazembradai/Documents/workspace-ggts-3.4.0.RELEASE/Parser-DCLL-CoffeeToCode/dcll.ctc.Parser/src/main/java/Users/hazembradai/Documents/workspace-ggts-3.4.0.RELEASE/Parser-DCLL-CoffeeToCode/dcll.ctc.Parser/targetChamp non initialisé dans le constructeurLe champ n'est pas initialisé dans le constructeur org.tsaap.questions.impl.DefaultAnswer.identifierAt DefaultAnswer.java:[lines 24-120]In class org.tsaap.questions.impl.DefaultAnswerIn DefaultAnswer.javaField org.tsaap.questions.impl.DefaultAnswer.identifierIn method org.tsaap.questions.impl.DefaultAnswer.equals(Object)At DefaultAnswer.java:[line 48]Champ non initialisé dans le constructeurLe champ n'est pas initialisé dans le constructeur org.tsaap.questions.impl.DefaultAnswer.identifierAt DefaultAnswer.java:[lines 24-120]In class org.tsaap.questions.impl.DefaultAnswerIn DefaultAnswer.javaField org.tsaap.questions.impl.DefaultAnswer.identifierIn method org.tsaap.questions.impl.DefaultAnswer.hashCode()At DefaultAnswer.java:[line 55]Dodgy codeChamp non initialisé dans le constructeur
+ +<p>Ce champ n'est jamais initialisé dans aucun constructeur, et est de ce fait <code>null</code> une fois l'objet initialisé. Soit il s'agit d'une erreur, soit il s'agit d'un design douteux puisque ce champ génèra une exception s'il est déréférencé avant toute initialisation.</p> + +
Champ jamais alimenté
\ No newline at end of file diff --git a/dcll.ctc.Parser/Findbugs_Config-Exclude_C2C.xml b/dcll.ctc.Parser/Findbugs_Config-Exclude_C2C.xml index 505342f..012c2f6 100644 --- a/dcll.ctc.Parser/Findbugs_Config-Exclude_C2C.xml +++ b/dcll.ctc.Parser/Findbugs_Config-Exclude_C2C.xml @@ -1,5 +1,17 @@ - - - - - \ No newline at end of file + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/dcll.ctc.Parser/pom.xml b/dcll.ctc.Parser/pom.xml index 5b51de4..80b0606 100644 --- a/dcll.ctc.Parser/pom.xml +++ b/dcll.ctc.Parser/pom.xml @@ -38,11 +38,18 @@ CheckStyle_Config_C2C.xml - - org.codehaus.mojo - findbugs-maven-plugin - 2.5.2 - + + org.codehaus.mojo + findbugs-maven-plugin + 2.5.3 + + Normal + Default + Findbugs_Config-Exclude_C2C.xml + true + + + org.codehaus.mojo cobertura-maven-plugin diff --git a/dcll.ctc.Parser/src/main/java/org/tsaap/questions/impl/DefaultAnswer.java b/dcll.ctc.Parser/src/main/java/org/tsaap/questions/impl/DefaultAnswer.java index 5a1def4..7e3521b 100644 --- a/dcll.ctc.Parser/src/main/java/org/tsaap/questions/impl/DefaultAnswer.java +++ b/dcll.ctc.Parser/src/main/java/org/tsaap/questions/impl/DefaultAnswer.java @@ -25,18 +25,18 @@ public class DefaultAnswer implements Answer { /** * gg. */ - private String textValue; + private String textValue = ""; /** */ private Float percentCredit; /** * identifier. */ - private String identifier; + private String identifier = ""; /** * feedback. */ - private String feedback; + private String feedback = ""; @Override public boolean equals(final Object o) { diff --git a/workspacemechanic b/workspacemechanic new file mode 160000 index 0000000..d01ebda --- /dev/null +++ b/workspacemechanic @@ -0,0 +1 @@ +Subproject commit d01ebdaeb92b931dec304f62b9bf4afda93cdb87