Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward slash in passwords are not escaped #160

Open
brainsiq opened this issue May 18, 2018 · 0 comments
Open

Forward slash in passwords are not escaped #160

brainsiq opened this issue May 18, 2018 · 0 comments

Comments

@brainsiq
Copy link

Rabbot is using the global escape function, which does not escape forward slashes. This prevents rabbot from connecting successfully.

e.g. If the credentials are username and /password then it will attempt to connect to: amqp://username:/password@rabbitmq:5672

This should be amqp://username:%2Fpassword@rabbitmq:5672

encodeURIComponent can't be used either because that will not encode a ' which according to amqplib should be encoded (https://developer.mozilla.org/en-US/docs/Glossary/percent-encoding) so I guess it should continue to use escape but manually encode any forward slashes.

aankur added a commit to aankur/rabbot that referenced this issue May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant