Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error handling #71

Open
ManoloTonto1 opened this issue Jul 12, 2023 · 3 comments · May be fixed by #73 or #109
Open

Better Error handling #71

ManoloTonto1 opened this issue Jul 12, 2023 · 3 comments · May be fixed by #73 or #109
Assignees

Comments

@ManoloTonto1
Copy link

I ran into an issue that my calendar did not have a getAllDayEndAt() property and I got an error which was property not found
I think it would be great to have a package with all the possible errors so we can better handle errors in production.

func (event *VEvent) getTimeProp(componentProperty ComponentProperty, expectAllDay bool) (time.Time, error) {
	timeProp := event.GetProperty(componentProperty)
	if timeProp == nil {
		return time.Time{}, errors.New("property not found")
	}
@arran4
Copy link
Owner

arran4 commented Jul 12, 2023

I think we can just add them to a file with consts, no need to introduce a whole new package. When my contract runs out I will consider this. Happy to review PRs and accept good ones too.

@ManoloTonto1 ManoloTonto1 linked a pull request Jul 12, 2023 that will close this issue
@arran4 arran4 self-assigned this Oct 15, 2024
@arran4
Copy link
Owner

arran4 commented Oct 15, 2024

Once again: ManoloTonto1#2

It's getting a bit long

@arran4
Copy link
Owner

arran4 commented Oct 15, 2024

We are getting high risk of regression. So I will probably have to do something by this w/e with this

@arran4 arran4 linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants