Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagram images path in site modules #762

Open
1 of 3 tasks
abelsromero opened this issue Feb 4, 2024 · 3 comments
Open
1 of 3 tasks

Fix diagram images path in site modules #762

abelsromero opened this issue Feb 4, 2024 · 3 comments

Comments

@abelsromero
Copy link
Member

abelsromero commented Feb 4, 2024

Thank you for taking your time to talk with us!

What is this issue about?

  • Bug report
  • Feature request
  • Question

Description

Using asciidoctorj-diagram with the maven-site modules causes diagram images to be created in the source path.

Environment information

@abelsromero abelsromero added the bug label Feb 4, 2024
@abelsromero abelsromero added this to the 3.0.1 milestone Feb 4, 2024
@abelsromero
Copy link
Member Author

abelsromero commented Feb 4, 2024

The issue is caused because the site converter converts to String and then Doxia (Maven's site component) creates the image files from it. Hence asciidoctor-diagram generates images in the only path available, the one where the source is.

The current workaround of setting imagesoutdir attribute won't work when the sources are found in different sub-folders.

@abelsromero
Copy link
Member Author

Related #349

@abelsromero
Copy link
Member Author

I am starting a conversation with the Maven team, because without changes in Doxia this cannot be fixed in a consistent way.

https://lists.apache.org/thread/z0thrxyv9tybot6xpkd8ft9nc1mc3nj9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant