Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can you support cloudflare-image without custom domain? #111

Closed
dulee-dev opened this issue Jan 23, 2024 · 1 comment · Fixed by #131
Closed

Can you support cloudflare-image without custom domain? #111

dulee-dev opened this issue Jan 23, 2024 · 1 comment · Fixed by #131

Comments

@dulee-dev
Copy link

cloudflare image also serve without custom domain
link

url sample of mine
https://imagedelivery.net/<ACCOUNT_HASH>/<IMAGE_ID>/
https://imagedelivery.net/sO38Ra7xK9C5jR-qJrdsOw/c0cac568-83b9-4c72-405d-2cf4f1b8d200/w=600,h=400

or is there any easy way to use custom url transformer?
@ascorbic ascorbic transferred this issue from ascorbic/unpic-img Jan 23, 2024
@ascorbic
Copy link
Owner

Certainly should be doable. It would need the domain to be added to https://github.com/ascorbic/unpic/blob/main/data/domains.json and the parsing logic updated here https://github.com/ascorbic/unpic/blob/main/src/transformers/cloudflare_images.ts

dawaltconley added a commit to dawaltconley/unpic that referenced this issue May 23, 2024
@dawaltconley
add support for cloudflare images without custom domain
925244b 
fixes ascorbic#111
dawaltconley added a commit to dawaltconley/unpic that referenced this issue May 23, 2024
@dawaltconley
add support for cloudflare images without custom domain
20ff39e 
fixes ascorbic#111
@dawaltconley dawaltconley mentioned this issue May 23, 2024
Merged
dawaltconley added a commit to dawaltconley/unpic that referenced this issue May 23, 2024
@dawaltconley
feat: add support for cloudflare images without custom domain (ascorb…
1166d48 
…ic#111)
ascorbic added a commit that referenced this issue Oct 26, 2024
@dawaltconley @ascorbic
feat: add support for cloudflare images without custom domain (#131)
320784b 
* feat: add support for cloudflare images without custom domain (#111)

* chore: format

* chore: format

* chore: format

---------

Co-authored-by: dawaltconley <[email protected]>
Co-authored-by: Matt Kane <[email protected]>
Co-authored-by: ascorbic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for cloudflare images without custom domain dawaltconley/unpic
2 participants
@ascorbic @dulee-dev