Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working with Cloudinary video thumbnails #112

Open
seancdavis opened this issue Jan 25, 2024 · 0 comments
Open

Working with Cloudinary video thumbnails #112

seancdavis opened this issue Jan 25, 2024 · 0 comments

Comments

@seancdavis
Copy link

There are two different ways to convert a Cloudinary video URL to a thumbnail image of the video:

  • Replace the file extension
  • Keep the file extension, but use f_jpg (or similar) transformation

In both cases, the assetType captured by this regex is video, which leads to an unsupported error.

Video thumbnails feel like a valid use case, and I'm happy to do the work to add the support.

But what's the right logic? Is it too opinionated to say if it's a video, then we check for a valid image extension on the URL?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seancdavis