Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions lack full support of type system features #1291

Closed
braingram opened this issue Jan 9, 2023 · 1 comment · Fixed by #1625
Closed

Extensions lack full support of type system features #1291

braingram opened this issue Jan 9, 2023 · 1 comment · Fixed by #1625
Milestone

Comments

@braingram
Copy link
Contributor

Extensions are unable to replace the type system due to lack of support for:

@braingram
Copy link
Contributor Author

Another example is run_modifying_hook:

self.run_modifying_hook("copy_to_new_asdf", validate=False)

This supports creating a new AsdfFile object from an existing (in memory) AsdfFile object by calling:

af = AsdfFile(an_existing_asdf_file_object) 

The coverage survey of downstream package tests showed that this was never used.
I found no equivalent for this hook in the new extension api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant