-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support slash-based aliases for LTS #193
Comments
The main problem is how the core asdf handles names, it can't use |
@augustobmoura ah, thank you for providing that context. I overlooked that helpful information. It does seem like supporting aliases containing slashes is a bit more involved and potentially related to asdf core. |
I wonder if when reading the legacy/.nvmrc file, we could do the conversion there? Then, Thoughts? |
Actually... There is a way of supporting .nvmrc files using the parse-legacy-file hook, I didn't see that hook before. |
I opened the #194 PR to add this translation at legacy file level, tested in my machine and it worked fine. Maybe we can leave the issue open for the |
We changed the way aliases work on #348, now you need to explicitly opt-in with dynamic ranges on legacy version files ( To enable it, you need to provide an export ASDF_NODEJS_LEGACY_FILE_DYNAMIC_STRATEGY=latest_installed
# OR
export ASDF_NODEJS_LEGACY_FILE_DYNAMIC_STRATEGY=latest_available Please update the plugin by running |
Support for aliases was added in #176, which is great! However, the support appears to use a dash-based naming convention, which diverges from nvm's slash-based naming convention.
If possible, it'd be helpful to align to (or at least support) the slash-based naming convention. Doing so would allow...
.nvmrc
files leveraging LTS aliases. E.g.lts/*
. (Add support to parsing lts/* aliases in legacy config files #194)asdf install nodejs lts/erbium
.The text was updated successfully, but these errors were encountered: